• New Defects reported by C

    From scan-admin@coverity.com@VERT to All on Thu May 7 19:14:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    40 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 645990: Control flow issues (NO_EFFECT)
    /writemsg.cpp: 414 in sbbs_t::writemsg(const char *, const char *, char *, int, int, const char *, const char *, const char **, const char **)()


    _____________________________________________________________________________________________
    *** CID 645990: Control flow issues (NO_EFFECT)
    /writemsg.cpp: 414 in sbbs_t::writemsg(const char *, const char *, char *, int, int, const char *, const char *, const char **, const char **)()
    408 free(buf);
    409 fclose(stream);
    410 return false;
    411 }
    412
    413 l = (long)ftell(stream); /* l now points to start of message */
    CID 645990: Control flow issues (NO_EFFECT)
    This less-than-zero comparison of an unsigned value is never true. "l < 0U".
    414 if (l < 0) {
    415 errormsg(WHERE, ERR_LEN, msgtmp, 0); 416 fclose(stream);
    417 close(file);
    418 free(buf);
    419 return false;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Sat May 9 12:48:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    15 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 15 of 15 defect(s)


    ** CID 646018: Error handling issues (CHECKED_RETURN)
    /mqtt_broker.cpp: 561 in mqtt5::Broker::broker_thread()()


    _____________________________________________________________________________________________
    *** CID 646018: Error handling issues (CHECKED_RETURN) /mqtt_broker.cpp: 561 in mqtt5::Broker::broker_thread()()
    555 break;
    556 }
    557
    558 #ifndef _WIN32
    559 if (m_wakeup_pipe[0] >= 0 && FD_ISSET(m_wakeup_pipe[0], &rfds)) {
    560 char buf[64];
    CID 646018: Error handling issues (CHECKED_RETURN)
    "read(int, void *, size_t)" returns the number of bytes read, but it is ignored.
    561 (void)read(m_wakeup_pipe[0], buf, sizeof(buf)); 562 }
    563 #endif
    564
    565 if (m_listen_sock >= 0 && FD_ISSET(m_listen_sock, &rfds))
    566 accept_connection(m_listen_sock);

    ** CID 646017: (CHECKED_RETURN)
    /mqtt_broker.cpp: 175 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()
    /mqtt_broker.cpp: 181 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()
    /mqtt_broker.cpp: 166 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()


    _____________________________________________________________________________________________
    *** CID 646017: (CHECKED_RETURN)
    /mqtt_broker.cpp: 175 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()
    169 closesocket(m_listen_sock);
    170 m_listen_sock = -1;
    171 return false;
    172 }
    173 } else {
    174 int off = 0;
    CID 646017: (CHECKED_RETURN)
    Calling "setsockopt(this->m_listen_sock, IPPROTO_IPV6, 26, (char const *)&off, 4U)" without checking return value. This library function may fail and return an error code.
    175 setsockopt(m_listen_sock, IPPROTO_IPV6, IPV6_V6ONLY, (const char *)&off, sizeof(off));
    176 struct sockaddr_in6 addr = {};
    177 addr.sin6_family = AF_INET6;
    178 addr.sin6_port = htons(port);
    179 addr.sin6_addr = in6addr_any;
    180 int opt = 1;
    /mqtt_broker.cpp: 181 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()
    175 setsockopt(m_listen_sock, IPPROTO_IPV6, IPV6_V6ONLY, (const char *)&off, sizeof(off));
    176 struct sockaddr_in6 addr = {};
    177 addr.sin6_family = AF_INET6;
    178 addr.sin6_port = htons(port);
    179 addr.sin6_addr = in6addr_any;
    180 int opt = 1;
    CID 646017: (CHECKED_RETURN)
    Calling "setsockopt(this->m_listen_sock, 1, 2, (char const *)&opt, 4U)" without checking return value. This library function may fail and return an error code.
    181 setsockopt(m_listen_sock, SOL_SOCKET, SO_REUSEADDR, (const char *)&opt, sizeof(opt));
    182 if (bind(m_listen_sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
    183 log(LOG_ERR, "MQTT broker: bind() port %u failed: %d", port, ERROR_VALUE);
    184 closesocket(m_listen_sock);
    185 m_listen_sock = -1;
    186 return false;
    /mqtt_broker.cpp: 166 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()
    160 }
    161 struct sockaddr_in addr = {};
    162 addr.sin_family = AF_INET;
    163 addr.sin_port = htons(port);
    164 addr.sin_addr.s_addr = INADDR_ANY;
    165 int opt = 1;
    CID 646017: (CHECKED_RETURN)
    Calling "setsockopt(this->m_listen_sock, 1, 2, (char const *)&opt, 4U)" without checking return value. This library function may fail and return an error code.
    166 setsockopt(m_listen_sock, SOL_SOCKET, SO_REUSEADDR, (const char *)&opt, sizeof(opt));
    167 if (bind(m_listen_sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
    168 log(LOG_ERR, "MQTT broker: bind() port %u failed: %d", port, ERROR_VALUE);
    169 closesocket(m_listen_sock);
    170 m_listen_sock = -1;
    171 return false;

    ** CID 646016: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 347 in mqtt5::Broker::local_subscribe(mqtt5::LocalClient *, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, int)::[lambda(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>) (instance 1)]::operator ()(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>) const()


    _____________________________________________________________________________________________
    *** CID 646016: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 347 in mqtt5::Broker::local_subscribe(mqtt5::LocalClient *, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, int)::[lambda(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>) (instance 1)]::operator ()(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>) const()
    341 {
    342 std::lock_guard<std::mutex> slock(client->sub_mutex); 343 client->subscriptions.push_back(topic);
    344 }
    345
    346 m_topics.match_retained(topic, [&](const std::string &, std::shared_ptr<Message> msg) {
    CID 646016: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "msg" is passed-by-value as parameter to "std::shared_ptr<mqtt5::Message>::shared_ptr(std::shared_ptr<mqtt5::Message> const &) /*explicit =default*/", when it could be moved instead.
    347 if (msg) deliver_to_local(client, msg);
    348 });
    349
    350 return 0;
    351 }
    352

    ** CID 646015: Error handling issues (CHECKED_RETURN)
    /mqtt_broker.cpp: 636 in mqtt5::Broker::accept_connection(int)()


    _____________________________________________________________________________________________
    *** CID 646015: Error handling issues (CHECKED_RETURN) /mqtt_broker.cpp: 636 in mqtt5::Broker::accept_connection(int)() 630 struct sockaddr_storage addr;
    631 socklen_t addrlen = sizeof(addr);
    632 int sock = accept(listen_sock, (struct sockaddr *)&addr, &addrlen);
    633 if (sock < 0) return;
    634
    635 int nodelay = 1;
    CID 646015: Error handling issues (CHECKED_RETURN)
    Calling "setsockopt(sock, IPPROTO_TCP, 1, (char *)&nodelay, 4U)" without checking return value. This library function may fail and return an error code.
    636 setsockopt(sock, IPPROTO_TCP, TCP_NODELAY, (char *)&nodelay, sizeof(nodelay));
    637
    638 CRYPT_SESSION tls_sess = CRYPT_UNUSED;
    639 int ret;
    640
    641 if (!do_cryptInit(broker_lprintf)) {

    ** CID 646029: Insecure data handling (TAINTED_SCALAR) /mqtt_protocol.cpp: 174 in mqtt5::Reader::read_utf8(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &)()


    _____________________________________________________________________________________________
    *** CID 646029: Insecure data handling (TAINTED_SCALAR) /mqtt_protocol.cpp: 174 in mqtt5::Reader::read_utf8(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &)()
    168
    169 bool Reader::read_utf8(std::string &out)
    170 {
    171 uint16_t len;
    172 if (!read_u16(len)) return false;
    173 if (m_pos + len > m_len) return false;
    CID 646029: Insecure data handling (TAINTED_SCALAR)
    Passing tainted expression "len" to "assign", which uses it as an offset. [Note: The source code implementation of the function has been overridden by a builtin model.]
    174 out.assign(reinterpret_cast<const char *>(m_data + m_pos), len);
    175 m_pos += len;
    176 return true;
    177 }
    178
    179 bool Reader::read_binary(std::vector<uint8_t> &out)

    ** CID 646028: Performance inefficiencies (AUTO_CAUSES_COPY) /mqtt_broker.cpp: 365 in mqtt5::Broker::route_publish(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>)::[lambda(const mqtt5::Subscriber &) (instance 1)]::operator ()(const mqtt5::Subscriber &) const()


    _____________________________________________________________________________________________
    *** CID 646028: Performance inefficiencies (AUTO_CAUSES_COPY) /mqtt_broker.cpp: 365 in mqtt5::Broker::route_publish(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>)::[lambda(const mqtt5::Subscriber &) (instance 1)]::operator ()(const mqtt5::Subscriber &) const()
    359
    360 std::unordered_map<std::string, const SubscriptionOptions *> delivered;
    361
    362 m_topics.publish(msg->topic, [&](const Subscriber &sub) {
    363 if (sub.opts.no_local && sub.client_id == sender_id) 364 return;
    CID 646028: Performance inefficiencies (AUTO_CAUSES_COPY)
    Using the "auto" keyword without an "&" causes the copy of an object of type "std::string".
    365 auto key = sub.client_id;
    366 if (delivered.count(key))
    367 return;
    368 delivered[key] = &sub.opts;
    369
    370 for (const auto &lc : m_local_clients) {

    ** CID 646027: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 303 in mqtt5::Broker::publish_sys(const char *, const void *, unsigned long)()


    _____________________________________________________________________________________________
    *** CID 646027: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 303 in mqtt5::Broker::publish_sys(const char *, const void *, unsigned long)()
    297 if (payload && len > 0)
    298 msg->payload.assign(static_cast<const uint8_t *>(payload),
    299 static_cast<const uint8_t *>(payload) + len);
    300 msg->created_at = time(nullptr);
    301
    302 std::lock_guard<std::recursive_mutex> lock(m_mutex);
    CID 646027: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "msg" is passed-by-value as parameter to "std::shared_ptr<mqtt5::Message>::shared_ptr(std::shared_ptr<mqtt5::Message> const &) /*explicit =default*/", when it could be moved instead.
    303 route_publish("$SYS", msg);
    304 }
    305
    306 void Broker::deregister_local(LocalClient *client)
    307 {
    308 std::lock_guard<std::recursive_mutex> lock(m_mutex);

    ** CID 646026: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 101 in mqtt5::Broker::build_psk_table()()


    _____________________________________________________________________________________________
    *** CID 646026: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 101 in mqtt5::Broker::build_psk_table()()
    95 if (user.misc & (DELETED | INACTIVE))
    96 continue;
    97 std::string alias(user.alias);
    98 std::string pass(user.pass);
    99 std::transform(alias.begin(), alias.end(), alias.begin(), ::tolower);
    100 std::transform(pass.begin(), pass.end(), pass.begin(), ::tolower);
    CID 646026: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "pass" is copied in call to copy assignment for class "std::string", when it could be moved instead.
    101 m_psk_table[alias] = pass;
    102 }
    103 log(LOG_DEBUG, "MQTT broker: loaded %zu PSK identities", m_psk_table.size());
    104 }
    105
    106 bool Broker::authenticate_psk(const std::string &identity, const std::string &password)

    ** CID 646025: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 971 in mqtt5::Broker::handle_subscribe(mqtt5::NetworkSession &, const unsigned char *, unsigned long)::[lambda(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>) (instance 1)]::operator ()(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>) const()


    _____________________________________________________________________________________________
    *** CID 646025: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 971 in mqtt5::Broker::handle_subscribe(mqtt5::NetworkSession &, const unsigned char *, unsigned long)::[lambda(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>) (instance 1)]::operator ()(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &, std::shared_ptr<mqtt5::Message>) const()
    965 if (!msg) return;
    966 if (msg->props.has(PROP_MESSAGE_EXPIRY)) {
    967 uint32_t expiry = msg->props.get_u32(PROP_MESSAGE_EXPIRY, 0);
    968 if (time(nullptr) - msg->created_at > (time_t)expiry)
    969 return;
    970 }
    CID 646025: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "msg" is passed-by-value as parameter to "std::shared_ptr<mqtt5::Message>::shared_ptr(std::shared_ptr<mqtt5::Message> const &) /*explicit =default*/", when it could be moved instead.
    971 deliver_to_network(session, msg, opts); 972 });
    973 }
    974
    975 reason_codes.push_back(tf.qos());
    976 }

    ** CID 646024: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 224 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()


    _____________________________________________________________________________________________
    *** CID 646024: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 224 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()
    218 auto msg = std::make_shared<Message>();
    219 msg->type = PUBLISH;
    220 msg->flags = 1;
    221 msg->topic = "$SYS/broker/version";
    222 msg->payload.assign(ver, ver + strlen(ver));
    223 msg->created_at = time(nullptr);
    CID 646024: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "msg" is passed-by-value as parameter to "std::shared_ptr<mqtt5::Message>::shared_ptr(std::shared_ptr<mqtt5::Message> const &) /*explicit =default*/", when it could be moved instead.
    224 m_topics.set_retained("$SYS/broker/version", msg);
    225 }
    226
    227 log(LOG_INFO, "MQTT broker: listening on port %u", port);
    228 return true;
    229 }

    ** CID 646023: (CHECKED_RETURN)
    /mqtt_broker.cpp: 204 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()
    /mqtt_broker.cpp: 205 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()


    _____________________________________________________________________________________________
    *** CID 646023: (CHECKED_RETURN)
    /mqtt_broker.cpp: 204 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()
    198 if (pipe(m_wakeup_pipe) < 0) {
    199 log(LOG_ERR, "MQTT broker: pipe() failed: %d", errno); 200 closesocket(m_listen_sock);
    201 m_listen_sock = -1;
    202 return false;
    203 }
    CID 646023: (CHECKED_RETURN)
    Calling "fcntl(this->m_wakeup_pipe[0], 4, 2048)" without checking return value. This library function may fail and return an error code.
    204 fcntl(m_wakeup_pipe[0], F_SETFL, O_NONBLOCK);
    205 fcntl(m_wakeup_pipe[1], F_SETFL, O_NONBLOCK);
    206 #endif
    207
    208 m_running = true;
    209 m_thread = std::thread(&Broker::broker_thread, this); /mqtt_broker.cpp: 205 in mqtt5::Broker::start(scfg_t *, unsigned short, int (*)(void *, int, const char *), void *)()
    199 log(LOG_ERR, "MQTT broker: pipe() failed: %d", errno); 200 closesocket(m_listen_sock);
    201 m_listen_sock = -1;
    202 return false;
    203 }
    204 fcntl(m_wakeup_pipe[0], F_SETFL, O_NONBLOCK);
    CID 646023: (CHECKED_RETURN)
    Calling "fcntl(this->m_wakeup_pipe[1], 4, 2048)" without checking return value. This library function may fail and return an error code.
    205 fcntl(m_wakeup_pipe[1], F_SETFL, O_NONBLOCK);
    206 #endif
    207
    208 m_running = true;
    209 m_thread = std::thread(&Broker::broker_thread, this);
    210

    ** CID 646022: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 715 in mqtt5::Broker::accept_connection(int)()


    _____________________________________________________________________________________________
    *** CID 646022: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 715 in mqtt5::Broker::accept_connection(int)() 709
    710 std::string temp_id = "pending-" + std::to_string(sock);
    711 std::lock_guard<std::recursive_mutex> lock(m_mutex);
    712 auto &session = m_sessions[temp_id];
    713 session.socket = sock;
    714 session.tls_sess = tls_sess;
    CID 646022: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "psk_id" is copied in call to copy assignment for class "std::string", when it could be moved instead.
    715 session.tls_psk_id = psk_id;
    716 session.last_activity = time(nullptr);
    717 log(LOG_DEBUG, "MQTT broker: new TLS connection on socket %d", sock);
    718 }
    719
    720 // Network data handling

    ** CID 646021: Concurrent data access violations (MISSING_LOCK) /mqtt_broker.cpp: 57 in mqtt5::Broker::instance()()


    _____________________________________________________________________________________________
    *** CID 646021: Concurrent data access violations (MISSING_LOCK) /mqtt_broker.cpp: 57 in mqtt5::Broker::instance()()
    51
    52 Broker *Broker::s_instance = nullptr;
    53 std::mutex Broker::s_instance_mutex;
    54
    55 Broker *Broker::instance()
    56 {
    CID 646021: Concurrent data access violations (MISSING_LOCK) >>> Accessing "mqtt5::Broker::s_instance" without holding lock "mqtt5::Broker::s_instance_mutex". Elsewhere, "mqtt5::Broker::s_instance" is written to with "mqtt5::Broker::s_instance_mutex" held 2 out of 2 times (1 of these accesses strongly imply that it is necessary).
    57 return s_instance;
    58 }
    59
    60 Broker::Broker()
    61 {
    62 }

    ** CID 646020: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 915 in mqtt5::Broker::handle_publish(mqtt5::NetworkSession &, unsigned char, const unsigned char *, unsigned long)()


    _____________________________________________________________________________________________
    *** CID 646020: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 915 in mqtt5::Broker::handle_publish(mqtt5::NetworkSession &, unsigned char, const unsigned char *, unsigned long)()
    909 teardown_network(session, 0x81);
    910 return;
    911 }
    912
    913 uint8_t qos = msg->qos();
    914
    CID 646020: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "msg" is passed-by-value as parameter to "std::shared_ptr<mqtt5::Message>::shared_ptr(std::shared_ptr<mqtt5::Message> const &) /*explicit =default*/", when it could be moved instead.
    915 route_publish(session.client_id, msg);
    916
    917 if (qos == 1) {
    918 send_to_network(session, build_ack(PUBACK, pid, 0)); 919 } else if (qos == 2) {
    920 session.rx_unacked[pid] = true;

    ** CID 646019: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 413 in mqtt5::Broker::deliver_to_network(mqtt5::NetworkSession &, std::shared_ptr<mqtt5::Message>, const mqtt5::SubscriptionOptions &)()


    _____________________________________________________________________________________________
    *** CID 646019: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 413 in mqtt5::Broker::deliver_to_network(mqtt5::NetworkSession &, std::shared_ptr<mqtt5::Message>, const mqtt5::SubscriptionOptions &)()
    407 auto pkt = build_publish(*msg, pid, false, qos,
    408 extra.empty() ? nullptr : &extra); 409 send_to_network(session, pkt);
    410
    411 if (qos > 0) {
    412 Queued q;
    CID 646019: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "msg" is copied in call to copy assignment for class "std::shared_ptr<mqtt5::Message>", when it could be moved instead.
    413 q.msg = msg;
    414 q.pid = pid;
    415 session.tx_unacked[pid] = std::move(q);
    416 }
    417 }
    418


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Mon May 11 15:35:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    4 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 4 of 4 defect(s)


    ** CID 646038: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 292 in mqtt5::Broker::publish_sys(const char *, const void *, unsigned long, const mqtt5::Properties *)()


    _____________________________________________________________________________________________
    *** CID 646038: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_broker.cpp: 292 in mqtt5::Broker::publish_sys(const char *, const void *, unsigned long, const mqtt5::Properties *)()
    286 static_cast<const uint8_t *>(payload) + len);
    287 if (props)
    288 msg->props = *props;
    289 msg->created_at = time(nullptr);
    290
    291 std::lock_guard<std::recursive_mutex> lock(m_mutex);
    CID 646038: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "msg" is passed-by-value as parameter to "std::shared_ptr<mqtt5::Message>::shared_ptr(std::shared_ptr<mqtt5::Message> const &) /*explicit =default*/", when it could be moved instead.
    292 route_publish("$SYS", msg);
    293 for (auto it_s = m_sessions.begin(); it_s != m_sessions.end(); ++it_s)
    294 if (!it_s->second.send_buf.empty())
    295 flush_network(it_s->second);
    296 }
    297

    ** CID 646037: Error handling issues (CHECKED_RETURN)
    /mqtt_client.cpp: 323 in mqtt5::Client::connect(const char *, unsigned short, const char *, const char *, const char *, int, int, int, const char *, const char *, const char *, const char *, const char *, const char *, scfg_t *, int (*)(int, const char *, ...))()


    _____________________________________________________________________________________________
    *** CID 646037: Error handling issues (CHECKED_RETURN) /mqtt_client.cpp: 323 in mqtt5::Client::connect(const char *, unsigned short, const char *, const char *, const char *, int, int, int, const char *, const char *, const char *, const char *, const char *, const char *, scfg_t *, int (*)(int, const char *, ...))()
    317
    318 cryptSetAttribute(m_tls_sess, CRYPT_SESSINFO_NETWORKSOCKET, m_sock);
    319 if (tls_mode == MQTT_TLS_PSK || tls_mode == MQTT_TLS_SBBS) {
    320 cryptSetAttribute(m_tls_sess, CRYPT_SESSINFO_TLS_OPTIONS, CRYPT_TLSOPTION_DISABLE_CERTVERIFY);
    321 cryptSetAttribute(m_tls_sess, CRYPT_SESSINFO_TLS_OPTIONS, CRYPT_TLSOPTION_DISABLE_NAMEVERIFY);
    322 }
    CID 646037: Error handling issues (CHECKED_RETURN)
    Calling "cryptSetAttributeString" without checking return value (as is done elsewhere 18 out of 21 times).
    323 cryptSetAttributeString(m_tls_sess, CRYPT_SESSINFO_SERVER_NAME, host, strlen(host));
    324 ret = cryptSetAttribute(m_tls_sess, CRYPT_SESSINFO_ACTIVE, 1);
    325 if (ret != CRYPT_OK) {
    326 if (lprintf) {
    327 char *estr = NULL;
    328 get_crypt_error_string(ret, m_tls_sess, &estr, "TLS handshake", NULL);

    ** CID 646036: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)


    _____________________________________________________________________________________________
    *** CID 646036: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /mqtt_client.cpp: 162 in mqtt5::Client::handle_packet(unsigned char, unsigned char, const unsigned char *, unsigned long)()
    156 ReceivedMessage rm;
    157 rm.topic = msg->topic;
    158 rm.payload = msg->payload;
    159 rm.mid = pid;
    160 rm.qos = msg->qos();
    161 rm.retain = msg->retain();
    CID 646036: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "rm" is copied and then passed-by-reference as parameter to STL insertion function "std::deque<mqtt5::ReceivedMessage, std::allocator<mqtt5::ReceivedMessage> >::push_back(std::deque<mqtt5::ReceivedMessage, std::allocator<mqtt5::ReceivedMessage> >::value_type const &)", when it could be moved instead.
    162 m_queue.push_back(rm);
    163 if (msg->qos() == 1)
    164 send_packet(build_ack(PUBACK, pid, 0));
    165 else if (msg->qos() == 2) {
    166 send_packet(build_ack(PUBREC, pid, 0));
    167 }

    ** CID 646035: Error handling issues (CHECKED_RETURN)
    /mqtt_client.cpp: 264 in mqtt5::Client::connect(const char *, unsigned short, const char *, const char *, const char *, int, int, int, const char *, const char *, const char *, const char *, const char *, const char *, scfg_t *, int (*)(int, const char *, ...))()


    _____________________________________________________________________________________________
    *** CID 646035: Error handling issues (CHECKED_RETURN) /mqtt_client.cpp: 264 in mqtt5::Client::connect(const char *, unsigned short, const char *, const char *, const char *, int, int, int, const char *, const char *, const char *, const char *, const char *, const char *, scfg_t *, int (*)(int, const char *, ...))()
    258 if (m_sock == INVALID_SOCKET) {
    259 m_last_error = -1;
    260 return -1;
    261 }
    262
    263 int nodelay = 1;
    CID 646035: Error handling issues (CHECKED_RETURN)
    Calling "setsockopt(this->m_sock, IPPROTO_TCP, 1, (char *)&nodelay, 4U)" without checking return value. This library function may fail and return an error code.
    264 setsockopt(m_sock, IPPROTO_TCP, TCP_NODELAY, (char *)&nodelay, sizeof(nodelay));
    265
    266 if (tls_mode != MQTT_TLS_DISABLED) {
    267 if (!do_cryptInit(lprintf)) {
    268 closesocket(m_sock);
    269 m_sock = INVALID_SOCKET;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Tue May 12 12:53:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 646043: Null pointer dereferences (FORWARD_NULL)
    /mqtt.cpp: 1095 in mqtt_startup()


    _____________________________________________________________________________________________
    *** CID 646043: Null pointer dereferences (FORWARD_NULL)
    /mqtt.cpp: 1095 in mqtt_startup()
    1089 }
    1090 broker = mqtt5::Broker::instance();
    1091 }
    1092 }
    1093
    1094 char client_id[256];
    CID 646043: Null pointer dereferences (FORWARD_NULL)
    Dereferencing null pointer "startup".
    1095 snprintf(client_id, sizeof(client_id), "sbbs-%s-%s-%s",
    1096 cfg->sys_id, mqtt->host, server_type_desc((enum server_type)startup->type));
    1097
    1098 auto *lc = broker->register_local(client_id, mqtt_local_message_callback, mqtt);
    1099 mqtt->local = lc;
    1100 mqtt->connected = true;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Tue Jun 23 12:49:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    2 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 2 of 2 defect(s)


    ** CID 646963: Concurrent data access violations (MISSING_LOCK) /echocfg.c: 863 in main()


    _____________________________________________________________________________________________
    *** CID 646963: Concurrent data access violations (MISSING_LOCK) /echocfg.c: 863 in main()
    857 uifc.mode |= UIFC_COLOR;
    858 break;
    859 case 'V':
    860 video_mode = atoi(argv[i] + 2); 861 break;
    862 case 'S':
    CID 646963: Concurrent data access violations (MISSING_LOCK) >>> Accessing "ciolib_initial_scaling" without holding lock "vstatlock". Elsewhere, "ciolib_initial_scaling" is written to with "vstatlock" held 5 out of 7 times.
    863 ciolib_initial_scaling = strtod(argv[i] + 2, NULL);
    864 break;
    865 default:
    866 USAGE:
    867 #ifdef _WIN32
    868 uifc.size = sizeof(uifc);

    ** CID 646962: Concurrent data access violations (MISSING_LOCK) /tmp/sbbs-Jun-23-2026/src/conio/sdl_con.c: 408 in sdl_init()


    _____________________________________________________________________________________________
    *** CID 646962: Concurrent data access violations (MISSING_LOCK) /tmp/sbbs-Jun-23-2026/src/conio/sdl_con.c: 408 in sdl_init()
    402
    403 /* Called from main thread only (Passes Event) */
    404 int sdl_init(int mode)
    405 {
    406 load_vmode(&vstat, ciolib_initial_mode);
    407 if (vstat.scaling < 1.0)
    CID 646962: Concurrent data access violations (MISSING_LOCK) >>> Accessing "ciolib_initial_scaling" without holding lock "vstatlock". Elsewhere, "ciolib_initial_scaling" is written to with "vstatlock" held 5 out of 7 times.
    408 vstat.scaling = ciolib_initial_scaling;
    409 if (vstat.scaling < 1.0)
    410 vstat.scaling = 1.0;
    411 // TODO: This is gross, why do we need it?
    412 vstat.winwidth = vstat.scrnwidth * vstat.scaling;
    413 vstat.winheight = vstat.scrnheight * vstat.scaling;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Fri Jun 26 12:49:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 647057: High impact quality (Y2K38_SAFETY)
    /mime.c: 43 in mimegetboundary()


    _____________________________________________________________________________________________
    *** CID 647057: High impact quality (Y2K38_SAFETY)
    /mime.c: 43 in mimegetboundary()
    37 int i, num;
    38 char* boundaryString = (char*)malloc(SIZEOF_MIMEBOUNDARY + 1);
    39
    40 /* A nonzero seed yields a deterministic boundary, so a message rendered
    41 * more than once (e.g. the DKIM sign/send two-pass) gets an identical 42 * boundary both times; seed==0 preserves the original time-seeded behavior. */
    CID 647057: High impact quality (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "time(NULL)" is cast to "unsigned int".
    43 srand(seed != 0 ? seed : (unsigned int)time(NULL));
    44 if (boundaryString == NULL)
    45 return NULL;
    46 for (i = 0; i < SIZEOF_MIMEBOUNDARY; i++) {
    47 num = (rand() % 62);
    48 if (num < 10)


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Tue Jun 30 12:45:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 647297: Concurrent data access violations (MISSING_LOCK) /tmp/sbbs-Jun-30-2026/src/conio/key.c: 34 in ciokey_init()


    _____________________________________________________________________________________________
    *** CID 647297: Concurrent data access violations (MISSING_LOCK) /tmp/sbbs-Jun-30-2026/src/conio/key.c: 34 in ciokey_init()
    28 static pthread_once_t ciokey_initialized = PTHREAD_ONCE_INIT;
    29
    30 static void
    31 ciokey_init(void)
    32 {
    33 memset(&state, 0, sizeof(state));
    CID 647297: Concurrent data access violations (MISSING_LOCK) >>> Accessing "state.events" without holding lock "ciokey_state.mutex". Elsewhere, "ciokey_state.events" is written to with "ciokey_state.mutex" held 6 out of 8 times.
    34 listInit(&state.events, 0);
    35 assert_pthread_mutex_init(&state.mutex, NULL);
    36 state.wake_event = CreateEvent(NULL, FALSE, FALSE, NULL);
    37 }
    38
    39 static void


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Mon Jul 6 12:49:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 648908: Resource leaks (RESOURCE_LEAK)
    /prntfile.cpp: 747 in sbbs_t::menu_exists_in(const char *, const char *, const char *, bool, char *)()


    _____________________________________________________________________________________________
    *** CID 648908: Resource leaks (RESOURCE_LEAK)
    /prntfile.cpp: 747 in sbbs_t::menu_exists_in(const char *, const char *, const char *, bool, char *)()
    741 if (*code == '.')
    742 *sub = '\0';
    743 if (mods)
    744 SAFEPRINTF3(prefix, "%stext/menu/%s%s", cfg.mods_dir, sub, code);
    745 else
    746 SAFEPRINTF3(prefix, "%smenu/%s%s", cfg.text_dir, sub, code);
    CID 648908: Resource leaks (RESOURCE_LEAK)
    Ignoring storage allocated by "_fullpath(path, prefix, 4096UL)" leaks it.
    747 FULLPATH(path, prefix, MAX_PATH);
    748 SAFECOPY(prefix, path);
    749 }
    750 // Display specified EXACT width file
    751 safe_snprintf(path, MAX_PATH, "%s.%ucol.%s", prefix, term->cols, ext);
    752 if (fexistcase(path))


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Thu Jul 23 12:50:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 651667: (INTEGER_OVERFLOW)
    /main.cpp: 2844 in output_thread(void *)()
    /main.cpp: 2806 in output_thread(void *)()


    _____________________________________________________________________________________________
    *** CID 651667: (INTEGER_OVERFLOW)
    /main.cpp: 2844 in output_thread(void *)()
    2838 int result = mqtt_pub_message(&mqtt, TOPIC_BBS, spy_topic, buf + bufbot, i, /* retain: */ false);
    2839 if (result != MQTT_SUCCESS)
    2840 lprintf(LOG_WARNING, "%s ERROR %d (%d) publishing node output (%u bytes): %s"
    2841 , node, result, errno, i, spy_topic);
    2842 }
    2843 if (spy_socket[sbbs->cfg.node_num - 1] != INVALID_SOCKET)
    CID 651667: (INTEGER_OVERFLOW)
    "i", which might have underflowed, is passed to "send(spy_socket[sbbs->cfg.node_num - 1], (char *)buf + bufbot, i, 0)".
    2844 if (sendsocket(spy_socket[sbbs->cfg.node_num - 1], (char*)buf + bufbot, i) != i && SOCKET_ERRNO != EPIPE)
    2845 errprintf(LOG_ERR, WHERE, "%s ERROR %d writing to spy socket", node, SOCKET_ERRNO);
    2846 #ifdef __unix__
    2847 if (uspy_socket[sbbs->cfg.node_num - 1] != INVALID_SOCKET)
    2848 if (sendsocket(uspy_socket[sbbs->cfg.node_num - 1], (char*)buf + bufbot, i) != i)
    2849 errprintf(LOG_ERR, WHERE, "%s ERROR %d writing to UNIX spy socket", node, SOCKET_ERRNO);
    /main.cpp: 2806 in output_thread(void *)()
    2800 }
    2801 }
    2802 pthread_mutex_unlock(&sbbs->ssh_mutex);
    2803 }
    2804 else
    2805 #endif
    CID 651667: (INTEGER_OVERFLOW)
    "sendbytes", which might have underflowed, is passed to "send(sbbs->client_socket.operator std::__atomic_base<int>::__int_type(), (char *)buf + bufbot, sendbytes, 0)".
    2806 i = sendsocket(sbbs->client_socket, (char*)buf + bufbot, sendbytes);
    2807 if (i == SOCKET_ERROR) {
    2808 SOCKET sock = sbbs->client_socket.load();
    2809 if (SOCKET_ERRNO == ENOTSOCK)
    2810 lprintf(LOG_NOTICE, "%04d %s [%s] client socket closed on send", sock, sbbs->client.protocol, sbbs->client_ipaddr);
    2811 else if (SOCKET_ERRNO == ECONNRESET)


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Tue Jul 28 21:16:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 651709: Resource leaks (RESOURCE_LEAK)
    /useredit.cpp: 108 in sbbs_t::useredit(int)()


    _____________________________________________________________________________________________
    *** CID 651709: Resource leaks (RESOURCE_LEAK)
    /useredit.cpp: 108 in sbbs_t::useredit(int)()
    102 if (user.comment[0] || i)
    103 bprintf(text[UeditCommentLine], i ? '+' : ' ' 104 , user.comment);
    105 else
    106 term->newline();
    107 if (localtime32(&user.laston, &tm) == NULL)
    CID 651709: Resource leaks (RESOURCE_LEAK)
    Variable "find_expr" going out of scope leaks the storage it points to. 108 return;
    109 bprintf(text[UserDates]
    110 , datestr(user.firston, str), datestr(user.expire, tmp)
    111 , datestr(user.laston, tmp2), tm.tm_hour, tm.tm_min);
    112
    113 bprintf(text[UserTimes]


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Mon Aug 10 13:31:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 652885: Integer handling issues (INTEGER_OVERFLOW)
    /useredit.cpp: 167 in sbbs_t::useredit(int)()


    _____________________________________________________________________________________________
    *** CID 652885: Integer handling issues (INTEGER_OVERFLOW) /useredit.cpp: 167 in sbbs_t::useredit(int)()
    161 bprintf(text[UeditPrompt], user.number, l);
    162 SAFEPRINTF4(str, "QG[]?/{}()%c%c%c%c", TERM_KEY_LEFT, TERM_KEY_RIGHT, TERM_KEY_HOME, TERM_KEY_END);
    163 if (user.level <= useron.level)
    164 SAFECAT(str, "ABCDEFHIJKLMNOPRSTUVWXYZ+~*$#"); 165 l = getkeys(str, l, K_UPPER | K_NOCRLF);
    166 if (l & 0x80000000L) {
    CID 652885: Integer handling issues (INTEGER_OVERFLOW)
    Expression "user.number", where "l & 0xffffffff7fffffffL" is known to be equal to -2147483649, overflows the type of "user.number", which is type "int".
    167 user.number = l & ~0x80000000L;
    168 continue;
    169 }
    170 if (IS_ALPHA(l) || strchr("~+*$/", l) != NULL) // non-alpha commands that prompt
    171 term->newline();
    172 switch (l) {


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Thu Aug 20 12:49:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 653403: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 214 in total_users()


    _____________________________________________________________________________________________
    *** CID 653403: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 214 in total_users()
    208 lock is a synchronous round-trip that dominates the cost of this scan
    209 when the data directory is network-mounted, and no amount of locking
    210 makes the result more current than the snapshot it already is. */
    211 do {
    212 got = 0;
    213 while (got < bufsize) {
    CID 653403: Insecure data handling (INTEGER_OVERFLOW)
    "64000UL - got", which might have underflowed, is passed to "read(file, buf + got, 64000UL - got)".
    214 ssize_t rd = read(file, buf + got, bufsize - got);
    215 if (rd <= 0)
    216 break;
    217 got += (size_t)rd;
    218 }
    219 for (size_t offset = 0; offset + USER_RECORD_LINE_LEN <= got; offset += USER_RECORD_LINE_LEN) {


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Sun Aug 30 12:51:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    3 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 3 of 3 defect(s)


    ** CID 654570: (CHECKED_RETURN)
    /xtrn_sec.cpp: 1223 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int)()
    /xtrn_sec.cpp: 1213 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int)()


    _____________________________________________________________________________________________
    *** CID 654570: (CHECKED_RETURN)
    /xtrn_sec.cpp: 1223 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int)()
    1217 int chmod_result = CHMOD(str, _S_IREAD);
    1218 #else
    1219 int chmod_result = CHMOD(str, S_IRUSR);
    1220 #endif
    1221 if (chmod_result != 0) {
    1222 errormsg(WHERE, ERR_WRITE, str, errno);
    CID 654570: (CHECKED_RETURN)
    Calling "remove(str)" without checking return value. This library function may fail and return an error code.
    1223 remove(str);
    1224 return false;
    1225 }
    1226 }
    1227
    1228 else if (type)
    /xtrn_sec.cpp: 1213 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int)()
    1207 }
    1208 bool write_ok = bbsdev_write(fp, lines, sizeof(lines) / sizeof(lines[0]));
    1209 if (fclose(fp) != 0)
    1210 write_ok = false;
    1211 if (!write_ok) {
    1212 errormsg(WHERE, ERR_WRITE, str, 0);
    CID 654570: (CHECKED_RETURN)
    Calling "remove(str)" without checking return value. This library function may fail and return an error code.
    1213 remove(str);
    1214 return false;
    1215 }
    1216 #if defined(_WIN32)
    1217 int chmod_result = CHMOD(str, _S_IREAD);
    1218 #else

    ** CID 654569: Memory - illegal accesses (OVERRUN)
    /xtrn_sec.cpp: 101 in bbsdev_language_tag_valid(const char *)()


    _____________________________________________________________________________________________
    *** CID 654569: Memory - illegal accesses (OVERRUN)
    /xtrn_sec.cpp: 101 in bbsdev_language_tag_valid(const char *)()
    95 || (lengths[at] == 4 && isdigit((unsigned char)parts[at][0])
    96 && bbsdev_subtag_chars(parts[at] + 1, 3, isalnum))))
    97 at++;
    98 while (at < count && lengths[at] == 1
    99 && tolower((unsigned char)parts[at][0]) != 'x') {
    100 at++;
    CID 654569: Memory - illegal accesses (OVERRUN)
    Overrunning array "lengths" of 32 8-byte elements at element index 32 (byte offset 263) using index "at" (which evaluates to 32).
    101 if (at == count || lengths[at] < 2)
    102 return false;
    103 while (at < count && lengths[at] >= 2)
    104 at++;
    105 }
    106 if (at < count && lengths[at] == 1 && tolower((unsigned char)parts[at][0]) == 'x')

    ** CID 654568: (RESOURCE_LEAK)
    /xtrn.cpp: 1925 in sbbs_t::external(const char *, int, const char *, const char *)()
    /xtrn.cpp: 1925 in sbbs_t::external(const char *, int, const char *, const char *)()


    _____________________________________________________________________________________________
    *** CID 654568: (RESOURCE_LEAK)
    /xtrn.cpp: 1925 in sbbs_t::external(const char *, int, const char *, const char *)()
    1919 dup2(fd, STDOUT_FILENO);
    1920 if (!(mode & EX_NOLOG))
    1921 dup2(fd, STDERR_FILENO);
    1922 if (fd > 2)
    1923 close(fd);
    1924 }
    CID 654568: (RESOURCE_LEAK)
    Handle variable "fd" going out of scope leaks the handle.
    1925 }
    1926
    1927 if (mode & EX_BG) /* background execution, detach child */
    1928 {
    1929 if (daemon(TRUE, FALSE) != 0)
    1930 lprintf(LOG_ERR, "!ERROR %d (%s) daemonizing: %s", errno, strerror(errno), argv[0]);
    /xtrn.cpp: 1925 in sbbs_t::external(const char *, int, const char *, const char *)()
    1919 dup2(fd, STDOUT_FILENO);
    1920 if (!(mode & EX_NOLOG))
    1921 dup2(fd, STDERR_FILENO);
    1922 if (fd > 2)
    1923 close(fd);
    1924 }
    CID 654568: (RESOURCE_LEAK)
    Handle variable "fd" going out of scope leaks the handle.
    1925 }
    1926
    1927 if (mode & EX_BG) /* background execution, detach child */
    1928 {
    1929 if (daemon(TRUE, FALSE) != 0)
    1930 lprintf(LOG_ERR, "!ERROR %d (%s) daemonizing: %s", errno, strerror(errno), argv[0]);


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Mon Sep 7 14:25:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    2 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 2 of 2 defect(s)


    ** CID 655740: Concurrent data access violations (MISSING_LOCK) /tmp/sbbs-Sep-07-2026/src/conio/sdl_con.c: 501 in sdl_init()


    _____________________________________________________________________________________________
    *** CID 655740: Concurrent data access violations (MISSING_LOCK) /tmp/sbbs-Sep-07-2026/src/conio/sdl_con.c: 501 in sdl_init()
    495 _beginthread(sdl_video_event_thread, 0, NULL);
    496 #endif
    497 sdl_user_func_ret(SDL_USEREVENT_INIT);
    498 sdl_init_mode(ciolib_initial_mode);
    499
    500 if(sdl_init_good) {
    CID 655740: Concurrent data access violations (MISSING_LOCK) >>> Accessing "fullscreen" without holding lock "win_mutex". Elsewhere, "fullscreen" is written to with "win_mutex" held 3 out of 3 times (3 of these accesses strongly imply that it is necessary).
    501 cio_api.mode=fullscreen?CIOLIB_MODE_SDL_FULLSCREEN:CIOLIB_MODE_SDL;
    502 #ifdef _WIN32
    503 FreeConsole();
    504 #endif
    505 cio_api.options |= CONIO_OPT_PALETTE_SETTING | CONIO_OPT_SET_TITLE | CONIO_OPT_SET_NAME | CONIO_OPT_SET_ICON | CONIO_OPT_EXTERNAL_SCALING | CONIO_OPT_KEY_EVENTS;
    506 return(0);

    ** CID 655739: (ATOMICITY)
    /main.cpp: 2782 in output_thread(void *)()
    /main.cpp: 2764 in output_thread(void *)()


    _____________________________________________________________________________________________
    *** CID 655739: (ATOMICITY)
    /main.cpp: 2782 in output_thread(void *)()
    2776 /* Handle the SSH error here. The lprintf inside GCESSTR
    2777 * runs while ssh_mutex is held; releasing+reacquiring it
    2778 * across the error report would make the error-handling
    2779 * sequence racy (ssh_errors++, online=FALSE) and is the
    2780 * wrong tradeoff for a fast log write. */
    2781 // coverity[SLEEP:SUPPRESS]
    CID 655739: (ATOMICITY)
    Using an unreliable value of "GCES_level" inside the second locked section. If the data that "GCES_level" depends on was changed by another thread, this use might be incorrect.
    2782 GCESSTR(err, node, sbbs->ssh_session, "pushing data");
    2783 sbbs->online = false; 2784 sendbytes = buftop - bufbot;
    2785 i = sendbytes; // Pretend we sent it all
    2786 }
    2787 else {
    /main.cpp: 2764 in output_thread(void *)()
    2758 }
    2759 if (sbbs->session_channel == -1) {
    2760 i = sendbytes; // Pretend we sent it all
    2761 }
    2762 else {
    2763 if (cryptStatusError((err = cryptSetAttribute(sbbs->ssh_session, CRYPT_SESSINFO_SSH_CHANNEL, sbbs->session_channel)))) {
    CID 655739: (ATOMICITY)
    Using an unreliable value of "GCES_level" inside the second locked section. If the data that "GCES_level" depends on was changed by another thread, this use might be incorrect.
    2764 GCESSTR(err, node, sbbs->ssh_session, "setting channel");
    2765 sbbs->online = false;
    2766 i = sendbytes; // Pretend we sent it all
    2767 }
    2768 else {
    2769 /*


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Mon Sep 14 13:45:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 656168: High impact quality (Y2K38_SAFETY)
    /main.cpp: 4542 in update_client_ini(sbbs_t *, const long *)()


    _____________________________________________________________________________________________
    *** CID 656168: High impact quality (Y2K38_SAFETY)
    /main.cpp: 4542 in update_client_ini(sbbs_t *, const long *)()
    4536 iniCloseFile(fp);
    4537 return;
    4538 }
    4539 iniSetUInteger(&ini, ROOT_SECTION, "user", (uint)sbbs->useron.number, NULL);
    4540 iniSetString(&ini, ROOT_SECTION, "name", sbbs->useron.alias, NULL);
    4541 if (done != NULL)
    CID 656168: High impact quality (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "*done" is cast to "uint".
    4542 iniSetUInteger(&ini, ROOT_SECTION, "done", (uint)*done, NULL);
    4543 iniWriteFile(fp, ini);
    4544 iniCloseFile(fp);
    4545 iniFreeStringList(ini);
    4546 }
    4547


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Fri Sep 25 14:41:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 656507: Error handling issues (CHECKED_RETURN) /tmp/sbbs-Sep-24-2026/src/xpdev/genwrap.c: 1530 in xp_pipe_open()


    _____________________________________________________________________________________________
    *** CID 656507: Error handling issues (CHECKED_RETURN) /tmp/sbbs-Sep-24-2026/src/xpdev/genwrap.c: 1530 in xp_pipe_open() 1524 FILE* fp;
    1525
    1526 /* A pipe is one-way, so the bidirectional mode gets a socket pair,
    1527 which is what the BSD popen() uses for it. */
    1528 if (socketpair(AF_UNIX, SOCK_STREAM, 0, sv) != 0)
    1529 return NULL;
    CID 656507: Error handling issues (CHECKED_RETURN)
    Calling "fcntl(sv[0], 2, 1)" without checking return value. This library function may fail and return an error code.
    1530 fcntl(sv[0], F_SETFD, FD_CLOEXEC); /* our end isn't the command's */
    1531 if ((pid = fork()) == 0) {
    1532 close(sv[0]);
    1533 dup2(sv[1], STDIN_FILENO);
    1534 dup2(sv[1], STDOUT_FILENO);
    1535 if (sv[1] > STDERR_FILENO)


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Thu Oct 1 10:10:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    5 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 5 of 5 defect(s)


    ** CID 656690: Error handling issues (CHECKED_RETURN)
    /websrvr.cpp: 2622 in js_add_cookieval(http_session_t *, const char *, const char *)()


    _____________________________________________________________________________________________
    *** CID 656690: Error handling issues (CHECKED_RETURN)
    /websrvr.cpp: 2622 in js_add_cookieval(http_session_t *, const char *, const char *)()
    2616 errprintf(LOG_ERR, WHERE, "%04d %-5s [%s] failed to create JSString for cookie value '%s', key=%s"
    2617 , session->socket, session->client.protocol, session->host_ip, value, key);
    2618 else {
    2619 lprintf(LOG_DEBUG, "%04d %-5s [%s] Adding cookie value %s=%s at pos %d"
    2620 , session->socket, session->client.protocol, session->host_ip, key, value, alen);
    2621 val = STRING_TO_JSVAL(js_str);
    CID 656690: Error handling issues (CHECKED_RETURN)
    Calling "JS_SetElement" without checking return value (as is done elsewhere 32 out of 40 times).
    2622 JS_SetElement(session->js_cx, keyarray, alen, &val); 2623 }
    2624 }
    2625
    2626 static void js_add_request_property(http_session_t * session, const char *key, const char *value, size_t len, bool writeable)
    2627 {

    ** CID 656689: Error handling issues (CHECKED_RETURN)
    /str.cpp: 1190 in sbbs_t::xfer_prot_menu(XFER_TYPE, user_t *, char *, unsigned long, const char *)()


    _____________________________________________________________________________________________
    *** CID 656689: Error handling issues (CHECKED_RETURN)
    /str.cpp: 1190 in sbbs_t::xfer_prot_menu(XFER_TYPE, user_t *, char *, unsigned long, const char *)()
    1184 for (int i = 0; i < cfg.total_prots; i++) {
    1185 if (available(i) && count + 1 < size)
    1186 keys[count++] = cfg.prot[i]->mnemonic; 1187 }
    1188 keys[count] = '\0';
    1189 if (extra_keys != nullptr)
    CID 656689: Error handling issues (CHECKED_RETURN)
    Calling "strlcat" without checking return value (as is done elsewhere 29 out of 31 times).
    1190 strlcat(keys, extra_keys, size);
    1191 set_cmd_keys(keys);
    1192 }
    1193 if (type == XFER_DOWNLOAD && current_file != nullptr)
    1194 menu("download", P_NOERROR);
    1195 bool menu_used = menu(prot_menu_file[type], P_NOERROR);

    ** CID 656688: Memory - corruptions (ARRAY_VS_SINGLETON)


    _____________________________________________________________________________________________
    *** CID 656688: Memory - corruptions (ARRAY_VS_SINGLETON) /js_console.cpp: 93 in js_key_str(JSContext *, char)()
    87 , CON_PROP_OUTPUT_RATE
    88 };
    89
    90 extern JSClass js_console_class;
    91 static JSString* js_key_str(JSContext* cx, char key)
    92 {
    CID 656688: Memory - corruptions (ARRAY_VS_SINGLETON)
    Passing "&key" to function "JS_NewStringCopyN" which uses it as an array. This might corrupt or misinterpret adjacent memory locations.
    93 return JS_NewStringCopyN(cx, &key, key == 0 ? 0 : 1);
    94 }
    95
    96 static JSBool js_console_get(JSContext *cx, JSObject *obj, jsid id, jsval *vp)
    97 {
    98 jsval idval;

    ** CID 656687: (CHECKED_RETURN)
    /qwk.cpp: 456 in sbbs_t::qwk_download()()
    /qwk.cpp: 417 in sbbs_t::qwk_download()()


    _____________________________________________________________________________________________
    *** CID 656687: (CHECKED_RETURN)
    /qwk.cpp: 456 in sbbs_t::qwk_download()()
    450 }
    451 if (!sent) {
    452 for (int i = 0; i < cfg.total_subs; i++)
    453 subscan[i].ptr = sav_ptr[i];
    454 last_ns_time = ns_time;
    455 }
    CID 656687: (CHECKED_RETURN)
    Calling "remove(path)" without checking return value. This library function may fail and return an error code.
    456 remove(path);
    457 free(sav_ptr);
    458 return sent;
    459 }
    460
    461 /****************************************************************************/
    /qwk.cpp: 417 in sbbs_t::qwk_download()()
    411 return false;
    412 }
    413 for (int i = 0; i < cfg.total_subs; i++)
    414 sav_ptr[i] = subscan[i].ptr;
    415 snprintf(path, sizeof path, "%s%s.qwk", cfg.temp_dir, cfg.sys_id);
    416 snprintf(fname, sizeof fname, "%s.qwk", cfg.sys_id);
    CID 656687: (CHECKED_RETURN)
    Calling "remove(path)" without checking return value. This library function may fail and return an error code.
    417 remove(path);
    418 if (pack_qwk(path, &msgcnt, /* prepack: */ false)) {
    419 off_t l = flength(path);
    420 bprintf(text[FiFilename], getfname(path));
    421 bprintf(text[FiFileSize], u64toac(l, tmp)
    422 , byte_estimate_to_str(l, tmp2, sizeof(tmp2), /* units: */ 1024, /* precision: */ 1));

    ** CID 656686: Error handling issues (CHECKED_RETURN)
    /websrvr.cpp: 2584 in js_add_queryval(http_session_t *, const char *, const char *)()


    _____________________________________________________________________________________________
    *** CID 656686: Error handling issues (CHECKED_RETURN)
    /websrvr.cpp: 2584 in js_add_queryval(http_session_t *, const char *, const char *)()
    2578 errprintf(LOG_ERR, WHERE, "%04d %-5s [%s] failed to create JSString for query value '%s', key=%s"
    2579 , session->socket, session->client.protocol, session->host_ip, value, key);
    2580 else {
    2581 lprintf(LOG_DEBUG, "%04d %-5s [%s] Adding query value %s=%s at pos %d"
    2582 , session->socket, session->client.protocol, session->host_ip, key, value, alen);
    2583 val = STRING_TO_JSVAL(js_str);
    CID 656686: Error handling issues (CHECKED_RETURN)
    Calling "JS_SetElement" without checking return value (as is done elsewhere 32 out of 40 times).
    2584 JS_SetElement(session->js_cx, keyarray, alen, &val); 2585 }
    2586 }
    2587
    2588 static void js_add_cookieval(http_session_t * session, const char *key, const char *value)
    2589 {


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Mon Oct 26 12:49:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    5 new defect(s) introduced to Synchronet found with Coverity Scan.
    3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 5 of 5 defect(s)


    ** CID 661079: Error handling issues (CHECKED_RETURN)
    /pack_rep.cpp: 114 in sbbs_t::pack_rep(unsigned int, unsigned int *)()


    _____________________________________________________________________________________________
    *** CID 661079: Error handling issues (CHECKED_RETURN)
    /pack_rep.cpp: 114 in sbbs_t::pack_rep(unsigned int, unsigned int *)()
    108 fexistcase(str);
    109 if ((hdrs = fopen(str, "a")) == NULL)
    110 errormsg(WHERE, ERR_CREATE, str, 0);
    111 }
    112 if (!(cfg.qhub[hubnum]->misc & QHUB_NOVOTING)) {
    113 SAFEPRINTF(str, "%sVOTING.DAT", cfg.temp_dir);
    CID 661079: Error handling issues (CHECKED_RETURN)
    Calling "fexistcase" without checking return value (as is done elsewhere 126 out of 136 times).
    114 fexistcase(str);
    115 if ((voting = fopen(str, "a")) == NULL)
    116 errormsg(WHERE, ERR_CREATE, str, 0);
    117 }
    118 /*********************/
    119 /* Pack new messages */

    ** CID 661078: (Y2K38_SAFETY)
    /pack_qwk.cpp: 628 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    /pack_qwk.cpp: 146 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    /pack_qwk.cpp: 623 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()


    _____________________________________________________________________________________________
    *** CID 661078: (Y2K38_SAFETY)
    /pack_qwk.cpp: 628 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    622 , tmp
    623 , (uint)elapsed
    624 , (uint64_t)((*msgcnt) + mailmsgs) / elapsed);
    625 lprintf(LOG_INFO, "packed %u messages (%s bytes) in %u seconds (%u msgs/sec)"
    626 , (*msgcnt) + mailmsgs
    627 , tmp
    CID 661078: (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "elapsed" is cast to "uint".
    628 , (uint)elapsed
    629 , (uint)(((*msgcnt) + mailmsgs) / elapsed)); 630 }
    631
    632 BOOL voting_data = FALSE;
    633 if (!fclose_checked(qwk)) {
    /pack_qwk.cpp: 146 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    140 return false;
    141 }
    142
    143 now = time(NULL);
    144 if (localtime_r(&now, &tm) == NULL) {
    145 fclose(stream);
    CID 661078: (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "this->now" is cast to "uint".
    146 errormsg(WHERE, ERR_CHK, "time", (uint)now); 147 return false;
    148 }
    149
    150 fprintf(stream, "%s\r\n%s\r\n%s\r\n%s, Sysop\r\n0000,%s\r\n"
    151 "%02u-%02u-%u,%02u:%02u:%02u\r\n" /pack_qwk.cpp: 623 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    617 byte_estimate_to_str(ftell(qwk), tmp, sizeof(tmp), 1024, 1);
    618 if (online == ON_REMOTE)
    619 bprintf("\r\n\r\n\1n\1hPacked %u messages (%s bytes) in %u seconds "
    620 "(%" PRIu64 " messages/second)."
    621 , (*msgcnt) + mailmsgs
    622 , tmp
    CID 661078: (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "elapsed" is cast to "uint".
    623 , (uint)elapsed
    624 , (uint64_t)((*msgcnt) + mailmsgs) / elapsed);
    625 lprintf(LOG_INFO, "packed %u messages (%s bytes) in %u seconds (%u msgs/sec)"
    626 , (*msgcnt) + mailmsgs
    627 , tmp
    628 , (uint)elapsed

    ** CID 661077: Security best practices violations (TOCTOU)
    /nopen.c: 217 in fmutex_close()


    _____________________________________________________________________________________________
    *** CID 661077: Security best practices violations (TOCTOU)
    /nopen.c: 217 in fmutex_close()
    211 #if !defined _WIN32 // should only be necessary (and possible) on *nix 212 // Remove before close, and only the file we opened: once our lock aged out and
    213 // was taken over, the file by this name is the new holder's 214 if (fstat(fm->fd, &fd_st) != 0) {
    215 error = errno;
    216 result = false;
    CID 661077: Security best practices violations (TOCTOU)
    Calling function "stat" to perform check on "fm->name".
    217 } else if (stat(fm->name, &name_st) != 0) {
    218 if (errno != ENOENT) {
    219 error = errno;
    220 result = false;
    221 }
    222 } else if (fd_st.st_dev == name_st.st_dev && fd_st.st_ino == name_st.st_ino) {

    ** CID 661076: (CHECKED_RETURN)
    /qwkjob.cpp: 412 in qwkjob_pack_locked(sbbs_t *, const qwkjob_host *, unsigned int, unsigned int *, char *, unsigned long)()
    /qwkjob.cpp: 397 in qwkjob_pack_locked(sbbs_t *, const qwkjob_host *, unsigned int, unsigned int *, char *, unsigned long)()


    _____________________________________________________________________________________________
    *** CID 661076: (CHECKED_RETURN)
    /qwkjob.cpp: 412 in qwkjob_pack_locked(sbbs_t *, const qwkjob_host *, unsigned int, unsigned int *, char *, unsigned long)()
    406 if (!qwkjob_replace_file(tmppath, qwkpath)) {
    407 #ifdef _WIN32
    408 sbbs->lprintf(LOG_ERR, "!ERROR (WinError %u) renaming %s to %s", (uint)GetLastError(), tmppath, qwkpath);
    409 #else
    410 sbbs->lprintf(LOG_ERR, "!ERROR %d (%s) renaming %s to %s", errno, strerror(errno), tmppath, qwkpath);
    411 #endif
    CID 661076: (CHECKED_RETURN)
    Calling "remove(tmppath)" without checking return value. This library function may fail and return an error code.
    412 remove(tmppath);
    413 return QWKJOB_FAILED;
    414 }
    415 sbbs->lprintf(LOG_INFO, "Packing completed: %s", qwkpath);
    416 sbbs->qwk_success(count, 0, /* prepack: */ 1);
    417 sbbs->putmsgptrs();
    /qwkjob.cpp: 397 in qwkjob_pack_locked(sbbs_t *, const qwkjob_host *, unsigned int, unsigned int *, char *, unsigned long)()
    391 if (qwkjob_terminated(host))
    392 return QWKJOB_FAILED;
    393 sbbs->lprintf(LOG_INFO, "Packing QWK Message Packet");
    394 SAFEPRINTF4(tmppath, "%sfile/%04u.%s.%d.qwk.tmp", sbbs->cfg.data_dir, usernum, qwkjob_local_host_name(), (int)getpid());
    395 SAFEPRINTF2(qwkpath, "%sfile/%04u.qwk", sbbs->cfg.data_dir, usernum);
    396 if (!sbbs->pack_qwk(tmppath, &count, /* prepack: */ true, &reason)) {
    CID 661076: (CHECKED_RETURN)
    Calling "remove(tmppath)" without checking return value. This library function may fail and return an error code.
    397 remove(tmppath);
    398 if (reason == QWKJOB_EMPTY)
    399 sbbs->lputs(LOG_INFO, "No packet created (no new messages)");
    400 return reason;
    401 }
    402 if (qwkjob_terminated(host)) {

    ** CID 661075: Incorrect expression (EVALUATION_ORDER)
    /pack_qwk.cpp: 798 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()


    _____________________________________________________________________________________________
    *** CID 661075: Incorrect expression (EVALUATION_ORDER)
    /pack_qwk.cpp: 798 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    792 lprintf(LOG_ERR, "libarchive error (%s) creating %s", error, packet);
    793 else
    794 lprintf(LOG_INFO, "libarchive created %s from %d files", packet, file_count);
    795 }
    796 if (flength(packet) < 1) {
    797 remove(packet);
    CID 661075: Incorrect expression (EVALUATION_ORDER)
    In argument #1 of "this->cmdstr(this->temp_cmd(ex), packet, path, NULL, ex)", a call is made to "this->temp_cmd(ex)". In argument #1 of this function, the object "ex" is modified. This object is also used in "ex", the argument #5 of the outer function call. The order in which these arguments are evaluated is not specified, and will vary between platforms.
    798 cmdstr(temp_cmd(ex), packet, path, NULL, ex);
    799 if ((i = external(cmdstr_output, ex | EX_WILDCARD)) != 0)
    800 errormsg(WHERE, ERR_EXEC, cmdstr_output, i); 801 if (flength(packet) < 1) {
    802 bputs(text[QWKCompressionFailed]);
    803 return false;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Tue Oct 27 12:48:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    2 new defect(s) introduced to Synchronet found with Coverity Scan.
    4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 2 of 2 defect(s)


    ** CID 661198: Error handling issues (CHECKED_RETURN)
    /pack_qwk.cpp: 660 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()


    _____________________________________________________________________________________________
    *** CID 661198: Error handling issues (CHECKED_RETURN)
    /pack_qwk.cpp: 660 in sbbs_t::pack_qwk(char *, unsigned int *, bool, qwkjob_result *)()
    654 SAFEPRINTF(str, "%sPERSONAL.NDX", cfg.temp_dir);
    655 if (!fclose_checked(personal)) {
    656 errormsg(WHERE, ERR_WRITE, str, 0);
    657 write_error = true;
    658 }
    659 if (!flength(str))
    CID 661198: Error handling issues (CHECKED_RETURN)
    Calling "remove(str)" without checking return value. This library function may fail and return an error code.
    660 remove(str);
    661 }
    662 term->newline();
    663
    664 // #1244
    665 SAFEPRINTF(str, "%sMESSAGES.DAT", cfg.temp_dir);

    ** CID 661197: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 1982 in finduserstr()


    _____________________________________________________________________________________________
    *** CID 661197: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 1982 in finduserstr()
    1976 overlapping a record another process holds locked fails; any record
    1977 not read in bulk is then read singly, taking the lock. */
    1978 size_t want = (size_t)count * USER_RECORD_LINE_LEN; 1979 size_t got = 0;
    1980 if (seekuserdat(file, unum)) {
    1981 while (got < want) {
    CID 661197: Insecure data handling (INTEGER_OVERFLOW)
    "want - got", which might have underflowed, is passed to "read(file, buf + got, want - got)".
    1982 ssize_t rd = read(file, buf + got, want - got);
    1983 if (rd <= 0)
    1984 break;
    1985 got += (size_t)rd;
    1986 }
    1987 }


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Thu Oct 29 13:36:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    4 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 4 of 4 defect(s)


    ** CID 661304: Concurrent data access violations (MISSING_LOCK) /js_socket.cpp: 374 in do_js_close(JSContext *, js_socket_private_t *, bool)()


    _____________________________________________________________________________________________
    *** CID 661304: Concurrent data access violations (MISSING_LOCK) /js_socket.cpp: 374 in do_js_close(JSContext *, js_socket_private_t *, bool)()
    368
    369 static void do_js_close(JSContext *cx, js_socket_private_t *p, bool finalize)
    370 {
    371 size_t i;
    372
    373 if (p->tls_pending) {
    CID 661304: Concurrent data access violations (MISSING_LOCK) >>> Accessing "p->tls_pending->sock" without holding lock "js_socket_tls_pending.mutex". Elsewhere, "js_socket_tls_pending.sock" is written to with "js_socket_tls_pending.mutex" held 1 out of 1 times.
    374 SOCKET sock = p->tls_pending->sock;
    375 // Cancellation precedes closing the notification endpoint.
    376 js_socket_cancel_tls_private(p);
    377 if (p->js_cb)
    378 remove_js_socket_event(cx, p->js_cb, sock);
    379 }

    ** CID 661303: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 1992 in finduserstr_ex()


    _____________________________________________________________________________________________
    *** CID 661303: Insecure data handling (INTEGER_OVERFLOW)
    /userdat.c: 1992 in finduserstr_ex()
    1986 overlapping a record another process holds locked fails; any record
    1987 not read in bulk is then read singly, taking the lock. */
    1988 size_t want = (size_t)count * USER_RECORD_LINE_LEN; 1989 size_t got = 0;
    1990 if (seekuserdat(file, unum)) {
    1991 while (got < want) {
    CID 661303: Insecure data handling (INTEGER_OVERFLOW)
    "want - got", which might have underflowed, is passed to "read(file, buf + got, want - got)".
    1992 ssize_t rd = read(file, buf + got, want - got);
    1993 if (rd <= 0)
    1994 break;
    1995 got += (size_t)rd;
    1996 }
    1997 }

    ** CID 661302: Error handling issues (CHECKED_RETURN)
    /js_socket.cpp: 2648 in js_socket_tls_thread(void *)()


    _____________________________________________________________________________________________
    *** CID 661302: Error handling issues (CHECKED_RETURN)
    /js_socket.cpp: 2648 in js_socket_tls_thread(void *)()
    2642 if (status == CRYPT_OK && !cancelled)
    2643 status = js_socket_activate_tls(pending->session, true, &pending->cert);
    2644 pthread_mutex_lock(&pending->mutex);
    2645 pending->status = status;
    2646 /* The event endpoint remains open until cancellation has set this flag. */
    2647 if (!pending->cancelled)
    CID 661302: Error handling issues (CHECKED_RETURN)
    Calling "send(pending->notify, "x", 1UL, 0)" without checking return value. This library function may fail and return an error code.
    2648 send(pending->notify, "x", 1, 0);
    2649 pthread_mutex_unlock(&pending->mutex);
    2650 js_socket_complete_tls_worker(pending);
    2651 }
    2652
    2653 JSBool js_socket_finish_tls(JSContext *cx, JSObject *obj)

    ** CID 661301: Concurrent data access violations (MISSING_LOCK) /js_socket.cpp: 2636 in js_socket_tls_thread(void *)()


    _____________________________________________________________________________________________
    *** CID 661301: Concurrent data access violations (MISSING_LOCK) /js_socket.cpp: 2636 in js_socket_tls_thread(void *)()
    2630 static void js_socket_tls_thread(void *arg)
    2631 {
    2632 js_socket_tls_pending *pending = static_cast<js_socket_tls_pending *>(arg);
    2633 SetThreadName("sbbs/jsTLS");
    2634 int status = CRYPT_ERROR_NOTINITED;
    2635 if (ssl_sync(pending->cfg, pending->logger)) {
    CID 661301: Concurrent data access violations (MISSING_LOCK) >>> Accessing "pending->session" without holding lock "js_socket_tls_pending.mutex". Elsewhere, "js_socket_tls_pending.session" is written to with "js_socket_tls_pending.mutex" held 1 out of 1 times.
    2636 status = add_private_key(pending->cfg, pending->logger, pending->session);
    2637 pending->key_added = status == CRYPT_OK;
    2638 }
    2639 pthread_mutex_lock(&pending->mutex);
    2640 bool cancelled = pending->cancelled;
    2641 pthread_mutex_unlock(&pending->mutex);


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Sun Nov 1 13:49:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    2 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 2 of 2 defect(s)


    ** CID 661497: (RESOURCE_LEAK)
    /xtrn.cpp: 1996 in sbbs_t::external(const char *, int, const char *, const char *, const char *)()
    /xtrn.cpp: 1996 in sbbs_t::external(const char *, int, const char *, const char *, const char *)()


    _____________________________________________________________________________________________
    *** CID 661497: (RESOURCE_LEAK)
    /xtrn.cpp: 1996 in sbbs_t::external(const char *, int, const char *, const char *, const char *)()
    1990 dup2(fd, STDOUT_FILENO);
    1991 if (!(mode & EX_NOLOG))
    1992 dup2(fd, STDERR_FILENO);
    1993 if (fd > 2)
    1994 close(fd);
    1995 }
    CID 661497: (RESOURCE_LEAK)
    Handle variable "fd" going out of scope leaks the handle.
    1996 }
    1997
    1998 if (mode & EX_BG) /* background execution, detach child */
    1999 {
    2000 if (daemon(TRUE, FALSE) != 0)
    2001 lprintf(LOG_ERR, "!ERROR %d (%s) daemonizing: %s", errno, strerror(errno), argv[0]);
    /xtrn.cpp: 1996 in sbbs_t::external(const char *, int, const char *, const char *, const char *)()
    1990 dup2(fd, STDOUT_FILENO);
    1991 if (!(mode & EX_NOLOG))
    1992 dup2(fd, STDERR_FILENO);
    1993 if (fd > 2)
    1994 close(fd);
    1995 }
    CID 661497: (RESOURCE_LEAK)
    Handle variable "fd" going out of scope leaks the handle.
    1996 }
    1997
    1998 if (mode & EX_BG) /* background execution, detach child */
    1999 {
    2000 if (daemon(TRUE, FALSE) != 0)
    2001 lprintf(LOG_ERR, "!ERROR %d (%s) daemonizing: %s", errno, strerror(errno), argv[0]);

    ** CID 661496: (CHECKED_RETURN)
    /xtrn_sec.cpp: 1369 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int, const xtrn_t *)()
    /xtrn_sec.cpp: 1359 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int, const xtrn_t *)()


    _____________________________________________________________________________________________
    *** CID 661496: (CHECKED_RETURN)
    /xtrn_sec.cpp: 1369 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int, const xtrn_t *)()
    1363 int chmod_result = CHMOD(str, _S_IREAD);
    1364 #else
    1365 int chmod_result = CHMOD(str, S_IRUSR);
    1366 #endif
    1367 if (chmod_result != 0) {
    1368 errormsg(WHERE, ERR_WRITE, str, errno);
    CID 661496: (CHECKED_RETURN)
    Calling "remove(str)" without checking return value. This library function may fail and return an error code.
    1369 remove(str);
    1370 return false;
    1371 }
    1372 }
    1373
    1374 else if (type == XTRN_DOORDROP) { /* DOORDROP.INI 1.0 */ /xtrn_sec.cpp: 1359 in sbbs_t::xtrndat(const char *, const char *, unsigned char, unsigned int, unsigned int, const xtrn_t *)()
    1353 }
    1354 bool write_ok = bbsdev_write(fp, lines, sizeof(lines) / sizeof(lines[0]));
    1355 if (fclose(fp) != 0)
    1356 write_ok = false;
    1357 if (!write_ok) {
    1358 errormsg(WHERE, ERR_WRITE, str, 0);
    CID 661496: (CHECKED_RETURN)
    Calling "remove(str)" without checking return value. This library function may fail and return an error code.
    1359 remove(str);
    1360 return false;
    1361 }
    1362 #if defined(_WIN32)
    1363 int chmod_result = CHMOD(str, _S_IREAD);
    1364 #else


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Thu Nov 5 13:47:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 661670: Insecure data handling (INTEGER_OVERFLOW)
    /js_socket.cpp: 1168 in js_socket_finish_connect(JSContext *, js_event_list *, bool)()


    _____________________________________________________________________________________________
    *** CID 661670: Insecure data handling (INTEGER_OVERFLOW) /js_socket.cpp: 1168 in js_socket_finish_connect(JSContext *, js_event_list *, bool)()
    1162 {
    1163 js_socket_private_t *p = (js_socket_private_t *)JS_GetPrivate(cx, event->cx);
    1164 struct js_connect_result result;
    1165 size_t received = 0;
    1166 jsrefcount rc = JS_SUSPENDREQUEST(cx);
    1167 while (received < sizeof result) {
    CID 661670: Insecure data handling (INTEGER_OVERFLOW)
    "8UL - received", which might have underflowed, is passed to "recv(event->data.connect.sv[0], (char *)&result + received, 8UL - received, 0)".
    1168 int rd = recv(event->data.connect.sv[0], (char *)&result + received, sizeof result - received, 0);
    1169 if (rd == SOCKET_ERROR && SOCKET_ERRNO == EINTR)
    1170 continue;
    1171 if (rd <= 0)
    1172 break;
    1173 received += rd;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Mon Nov 9 13:48:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 661775: Insecure data handling (TAINTED_SCALAR)


    _____________________________________________________________________________________________
    *** CID 661775: Insecure data handling (TAINTED_SCALAR)
    /str.cpp: 655 in sbbs_t::read_sif_dat(char *, char *)()
    649 return;
    650 }
    651 length = read(file, buf, length);
    652 if (length < 0)
    653 length = 0;
    654 close(file);
    CID 661775: Insecure data handling (TAINTED_SCALAR)
    Passing tainted expression "*buf" to "sof", which uses it as an offset. 655 sof(siffile, buf, length);
    656 free(buf);
    657 }
    658
    659 static bool is_template_char(char ch)
    660 {


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Sat Nov 14 13:47:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 662148: High impact quality (Y2K38_SAFETY)
    /upload.cpp: 69 in sbbs_t::uploadfile(smbmsg_t *, long)()


    _____________________________________________________________________________________________
    *** CID 662148: High impact quality (Y2K38_SAFETY)
    /upload.cpp: 69 in sbbs_t::uploadfile(smbmsg_t *, long)()
    63 bprintf(text[FileNotReceived], f->name);
    64 llprintf(LOG_NOTICE, "U!", "attempted to upload %s to %s %s (Not received)"
    65 , f->name
    66 , cfg.lib[cfg.dir[f->dir]->lib]->sname, cfg.dir[f->dir]->sname);
    67 return false;
    68 }
    CID 662148: High impact quality (Y2K38_SAFETY)
    A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "fdate(path)" is cast to "uint32_t".
    69 f->hdr.when_written.time = (uint32_t)fdate(path);
    70 for (i = 0; i < cfg.total_ftests; i++)
    71 if (file_type_match(f->name, cfg.ftest[i]->ext)) {
    72 if (!chk_ar(cfg.ftest[i]->ar, &useron, &client))
    73 continue;
    74 attr(LIGHTGRAY);


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to All on Tue Nov 17 13:48:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.
    1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 662206: Error handling issues (CHECKED_RETURN)
    /js_file.cpp: 2457 in js_file_set(JSContext *, JSObject *, long, int, unsigned long *)()


    _____________________________________________________________________________________________
    *** CID 662206: Error handling issues (CHECKED_RETURN)
    /js_file.cpp: 2457 in js_file_set(JSContext *, JSObject *, long, int, unsigned long *)()
    2451 jsdouble pos;
    2452 if (!JS_ValueToNumber(cx, *vp, &pos)) 2453 return JS_FALSE;
    2454 if (!(pos >= 0))
    2455 pos = 0;
    2456 rc = JS_SUSPENDREQUEST(cx);
    CID 662206: Error handling issues (CHECKED_RETURN)
    Calling "fseeko(p->fp, (off_t)pos, 0)" without checking return value. This library function may fail and return an error code.
    2457 fseeko(p->fp, (off_t)pos, SEEK_SET); 2458 JS_RESUMEREQUEST(cx, rc);
    2459 }
    2460 break;
    2461 case FILE_PROP_DATE:
    2462 if (!JS_ValueToECMAUint32(cx, *vp, &u))


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Sat Nov 21 13:47:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    1 new defect(s) introduced to Synchronet found with Coverity Scan.


    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)


    ** CID 662403: Incorrect expression (SIZEOF_MISMATCH)
    /scfglib1.c: 553 in read_domains_cfg_file()


    _____________________________________________________________________________________________
    *** CID 662403: Incorrect expression (SIZEOF_MISMATCH)
    /scfglib1.c: 553 in read_domains_cfg_file()
    547
    548 SAFEPRINTF2(path, "%s%s", cfg->ctrl_dir, fname);
    549 if ((fp = fnopen(NULL, path, O_RDONLY)) == NULL)
    550 return true;
    551 if ((names = strListInit()) == NULL) {
    552 fclose(fp);
    CID 662403: Incorrect expression (SIZEOF_MISMATCH)
    Passing argument "error" of type "char *" and argument "8UL /* sizeof (char *) */" to function "allocerr" is suspicious.
    553 return allocerr(error, maxerrlen, fname, "domain list", sizeof(char*));
    554 }
    555 while (fgets(line, sizeof line, fp) != NULL) {
    556 if (++lines > DOMAINS_CFG_MAX_LINES) {
    557 snprintf(error, maxerrlen, "%s: only the first %d lines were read", path, DOMAINS_CFG_MAX_LINES);
    558 break;


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From scan-admin@coverity.com@VERT to cov-scan@synchro.net on Sun Nov 22 13:48:00 2026
    Hi,

    Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

    10 new defect(s) introduced to Synchronet found with Coverity Scan.
    6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

    New defect(s) Reported-by: Coverity Scan
    Showing 10 of 10 defect(s)


    ** CID 662429: Resource leaks (RESOURCE_LEAK)
    /bulkmail.cpp: 194 in sbbs_t::bulkmailhdr(smb_t *, smbmsg_t *, unsigned int, bool *)()


    _____________________________________________________________________________________________
    *** CID 662429: Resource leaks (RESOURCE_LEAK)
    /bulkmail.cpp: 194 in sbbs_t::bulkmailhdr(smb_t *, smbmsg_t *, unsigned int, bool *)()
    188 return 0;
    189 }
    190 local_copy = false;
    191 }
    192
    193 if ((i = smb_copymsgmem(NULL, &newmsg, msg)) != SMB_SUCCESS) >>> CID 662429: Resource leaks (RESOURCE_LEAK)
    Variable "newmsg" going out of scope leaks the storage "newmsg.hfield_dat" points to.
    194 return i;
    195
    196 SAFECOPY(str, user.alias);
    197 smb_hfield_str(&newmsg, RECIPIENT, str);
    198
    199 if (forward) {

    ** CID 662428: Null pointer dereferences (FORWARD_NULL)


    _____________________________________________________________________________________________
    *** CID 662428: Null pointer dereferences (FORWARD_NULL)
    /websrvr.cpp: 6955 in exec_ssjs(http_session_t *, char *)()
    6949 if (session->req.post_data && session->req.post_data[0]) {
    6950 if (session->req.post_len <= MAX_POST_LEN) {
    6951 js_add_request_property(session, "post_data", session->req.post_data, session->req.post_len, /* writeable: */ false);
    6952 js_parse_query(session, session->req.post_data);
    6953 }
    6954 }
    CID 662428: Null pointer dereferences (FORWARD_NULL)
    Passing "session" to "parse_js_headers", which dereferences null "session->js_cookie".
    6955 parse_js_headers(session);
    6956
    6957 do {
    6958 /* RUN SCRIPT */
    6959 JS_ClearPendingException(session->js_cx);
    6960

    ** CID 662427: Resource leaks (RESOURCE_LEAK)
    /bulkmail.cpp: 194 in sbbs_t::bulkmailhdr(smb_t *, smbmsg_t *, unsigned int, bool *)()


    _____________________________________________________________________________________________
    *** CID 662427: Resource leaks (RESOURCE_LEAK)
    /bulkmail.cpp: 194 in sbbs_t::bulkmailhdr(smb_t *, smbmsg_t *, unsigned int, bool *)()
    188 return 0;
    189 }
    190 local_copy = false;
    191 }
    192
    193 if ((i = smb_copymsgmem(NULL, &newmsg, msg)) != SMB_SUCCESS) >>> CID 662427: Resource leaks (RESOURCE_LEAK)
    Variable "newmsg" going out of scope leaks the storage "newmsg.dfield" points to.
    194 return i;
    195
    196 SAFECOPY(str, user.alias);
    197 smb_hfield_str(&newmsg, RECIPIENT, str);
    198
    199 if (forward) {

    ** CID 662426: Insecure data handling (INTEGER_OVERFLOW)
    /getmail.c: 151 in mail_stored_bytes()


    _____________________________________________________________________________________________
    *** CID 662426: Insecure data handling (INTEGER_OVERFLOW)
    /getmail.c: 151 in mail_stored_bytes()
    145 datlen = 0;
    146 for (d = 0; d < hdr.total_dfields; d++) {
    147 if (d < fields)
    148 memcpy(&dfield, buf + sizeof(hdr) + (d * sizeof(dfield)), sizeof dfield);
    149 else {
    150 /* More data fields than the block read holds */
    CID 662426: Insecure data handling (INTEGER_OVERFLOW)
    The cast of "(off_t)list[i].offset + 70UL + d * 10UL" to a signed type could result in a negative number.
    151 if (d == fields
    152 && lseek(file, (off_t)list[i].offset + sizeof(hdr) + (d * sizeof(dfield)), SEEK_SET) == -1)
    153 break;
    154 if (read(file, &dfield, sizeof dfield) != sizeof dfield)
    155 break;
    156 }

    ** CID 662425: Resource leaks (RESOURCE_LEAK)
    /netmail.cpp: 923 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned int)()


    _____________________________________________________________________________________________
    *** CID 662425: Resource leaks (RESOURCE_LEAK)
    /netmail.cpp: 923 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned int)()
    917 errormsg(WHERE, ERR_OPEN, str, O_WRONLY | O_CREAT | O_EXCL);
    918 return;
    919 }
    920 if (write(fido, &hdr, sizeof(hdr)) != sizeof hdr) {
    921 free(qwkbuf);
    922 errormsg(WHERE, ERR_WRITE, str, sizeof hdr);
    CID 662425: Resource leaks (RESOURCE_LEAK)
    Handle variable "fido" going out of scope leaks the handle.
    923 return;
    924 }
    925
    926 pt_zone_kludge(&hdr, fido);
    927
    928 if (cfg.netmail_misc & NMAIL_DIRECT) {

    ** CID 662424: (FORWARD_NULL)


    _____________________________________________________________________________________________
    *** CID 662424: (FORWARD_NULL)
    /websrvr.cpp: 6947 in exec_ssjs(http_session_t *, char *)()
    6941 js_add_request_prop(session, "remote_ip", session->host_ip); 6942 js_add_request_prop(session, "remote_host", session->host_name);
    6943 js_add_request_prop(session, "lib", libnum_is_valid(&scfg, session->libnum) ? scfg.lib[session->libnum]->sname : NULL);
    6944 js_add_request_prop(session, "dir", dirnum_is_valid(&scfg, session->file.dir) ? scfg.dir[session->file.dir]->code : NULL);
    6945 if (session->req.query_str[0]) {
    6946 js_add_request_prop(session, "query_string", session->req.query_str);
    CID 662424: (FORWARD_NULL)
    Passing "session" to "js_parse_query", which dereferences null "session->js_query".
    6947 js_parse_query(session, session->req.query_str);
    6948 }
    6949 if (session->req.post_data && session->req.post_data[0]) {
    6950 if (session->req.post_len <= MAX_POST_LEN) {
    6951 js_add_request_property(session, "post_data", session->req.post_data, session->req.post_len, /* writeable: */ false);
    6952 js_parse_query(session, session->req.post_data);
    /websrvr.cpp: 6952 in exec_ssjs(http_session_t *, char *)()
    6946 js_add_request_prop(session, "query_string", session->req.query_str);
    6947 js_parse_query(session, session->req.query_str);
    6948 }
    6949 if (session->req.post_data && session->req.post_data[0]) {
    6950 if (session->req.post_len <= MAX_POST_LEN) {
    6951 js_add_request_property(session, "post_data", session->req.post_data, session->req.post_len, /* writeable: */ false);
    CID 662424: (FORWARD_NULL)
    Passing "session" to "js_parse_query", which dereferences null "session->js_query".
    6952 js_parse_query(session, session->req.post_data);
    6953 }
    6954 }
    6955 parse_js_headers(session);
    6956
    6957 do {

    ** CID 662423: Resource leaks (RESOURCE_LEAK)
    /bulkmail.cpp: 194 in sbbs_t::bulkmailhdr(smb_t *, smbmsg_t *, unsigned int, bool *)()


    _____________________________________________________________________________________________
    *** CID 662423: Resource leaks (RESOURCE_LEAK)
    /bulkmail.cpp: 194 in sbbs_t::bulkmailhdr(smb_t *, smbmsg_t *, unsigned int, bool *)()
    188 return 0;
    189 }
    190 local_copy = false;
    191 }
    192
    193 if ((i = smb_copymsgmem(NULL, &newmsg, msg)) != SMB_SUCCESS) >>> CID 662423: Resource leaks (RESOURCE_LEAK)
    Variable "newmsg" going out of scope leaks the storage "newmsg.hfield" points to.
    194 return i;
    195
    196 SAFECOPY(str, user.alias);
    197 smb_hfield_str(&newmsg, RECIPIENT, str);
    198
    199 if (forward) {

    ** CID 662422: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)


    _____________________________________________________________________________________________
    *** CID 662422: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /web_block.hpp: 339 in webBlock::parse(char **, std::vector<webBlock::rule, std::allocator<webBlock::rule>> &)()
    333 r.filter_duration = (uint)iniGetDuration(ini, section, "FilterDuration", 0);
    334 }
    335 if (iniGetExistingValue(ini, section, "FilterSilent", nullptr, nullptr) != nullptr) {
    336 r.has_filter_silent = true;
    337 r.filter_silent = iniGetBool(ini, section, "FilterSilent", false);
    338 }
    CID 662422: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "r" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<webBlock::rule, std::allocator<webBlock::rule> >::push_back(std::vector<webBlock::rule, std::allocator<webBlock::rule> >::value_type const &)", when it could be moved instead.
    339 loaded.push_back(r);
    340 }
    341 iniFreeStringList(all);
    342 iniFreeStringList(sections);
    343 }
    344 };
    345

    ** CID 662421: Insecure data handling (TAINTED_SCALAR)
    /getmail.c: 146 in mail_stored_bytes()


    _____________________________________________________________________________________________
    *** CID 662421: Insecure data handling (TAINTED_SCALAR)
    /getmail.c: 146 in mail_stored_bytes()
    140 if (memcmp(hdr.msghdr_id, SHD_HEADER_ID, LEN_HEADER_ID) != 0
    141 || hdr.number != list[i].number
    142 || (hdr.attr & MSG_DELETE))
    143 continue;
    144 fields = (uint)((rd - sizeof(hdr)) / sizeof(dfield)); 145 datlen = 0;
    CID 662421: Insecure data handling (TAINTED_SCALAR)
    Using tainted variable "hdr.total_dfields" as a loop boundary.
    146 for (d = 0; d < hdr.total_dfields; d++) {
    147 if (d < fields)
    148 memcpy(&dfield, buf + sizeof(hdr) + (d * sizeof(dfield)), sizeof dfield);
    149 else {
    150 /* More data fields than the block read holds */
    151 if (d == fields

    ** CID 662420: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /websrvr.cpp: 3057 in forwarded_client(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &)()


    _____________________________________________________________________________________________
    *** CID 662420: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) /websrvr.cpp: 3057 in forwarded_client(const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> &)()
    3051 size_t first = addr.find_first_not_of(" \t");
    3052 size_t last = addr.find_last_not_of(" \t");
    3053 addr = (first == std::string::npos) ? "" : addr.substr(first, last - first + 1);
    3054 uint8_t ip_addr[16];
    3055 if (inet_pton(AF_INET, addr.c_str(), ip_addr) != 1 && inet_pton(AF_INET6, addr.c_str(), ip_addr) != 1)
    3056 return std::string();
    CID 662420: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "addr" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::push_back(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::value_type const &)", when it could be moved instead.
    3057 addrs.push_back(addr);
    3058 start = end + 1;
    3059 }
    3060 if (strListCount(proxy_trust) < 1)
    3061 return addrs.back();
    3062 for (auto it = addrs.rbegin(); it != addrs.rend(); ++it) {


    ________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



    ---
    * Synchronet * Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net